Clean up constraint groups #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! 💃
In #749, I thought about making each module (trace, subplot and component) list which keys need to be relink on redraws. At that time, it sounds like a bigger hassle that it was worth. But now, with almost 2-years worth of additional tests, we could maybe try to swap the generic loop-over-all-keys relink step with something more fine-grained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2462
The problem was that
_axisConstraintGroupsgets reset in cartesian-only code, so with no cartesian module, the old one just gets added back in byrelinkPrivateKeys. So I cleaned that up, but also realized that without cartesian we don't even need to do some of the steps inPlotly.plot(including the one that errored) 🐎 In fact either one of those would have been enough to fix this bug, but I figured both can't hurt.@etpinard we should really rethink
relinkPrivateKeys- can we perhaps figure out which keys we really need to relink, and give them some stronger marker than just the generic underscore, which also means private, not an attribute? There are probably other keys that can cause similar problems...